Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.dark class for dark mode #349

Closed
xfq opened this issue Apr 15, 2024 · 3 comments · Fixed by #350
Closed

.dark class for dark mode #349

xfq opened this issue Apr 15, 2024 · 3 comments · Fixed by #350
Assignees
@deniak

Comments

@xfq
Copy link
Member

xfq commented Apr 15, 2024

It would be useful to add a .dark class via fixup.js when the spec is in dark mode, because many specs have customized styles and we can adapt the styles using media query using :not(.dark) in specs.

/cc @deniak
@xfq xfq mentioned this issue Apr 15, 2024
Open
@deniak deniak mentioned this issue Apr 16, 2024
Merged
@deniak
Copy link
Member

deniak commented Apr 16, 2024

I've submitted a PR to add a class darkmode: #350

@deniak deniak self-assigned this Apr 16, 2024
@xfq
Copy link
Member Author

xfq commented Apr 23, 2024

There seems to be a bug. My system is in light mode and I selected auto, but there is still a darkmode class on body.

@xfq xfq reopened this Apr 23, 2024
@deniak
Copy link
Member

deniak commented Apr 24, 2024

Fixed by #352

@deniak deniak closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deniak deniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixup.js: remove matomo + add a darkmode class to body element w3c/tr-design
2 participants
@deniak @xfq