Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special character between trace context fieds #2

Closed
bogdandrutu opened this issue Apr 10, 2017 · 4 comments
Closed

Special character between trace context fieds #2

bogdandrutu opened this issue Apr 10, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@bogdandrutu
Copy link
Contributor

One of the request was to add an extra human-readable character between the trace context fields. The current proposal was to not have this extra character.

Proposal to use '-' character between version/trace_id/span_id/options:
Value = 00-4bf92f3577b34da6a3ce929d0e0e4736-00f067aa0ba902b7-01000000

This proposal will allow SREs to easily copy-paste or parse the trace-id/span-id/options if needed.

@wu-sheng
Copy link
Contributor

In skywalking, we use '|' to split right now. Here is a sample context:

trace_id_A|100|REMOTE_APP|10.2.3.16:8080|Trace.global.id.123|1

trace_id and Trace.global.id include '.' and '-' , and that is why we choice '|' at first place.

@wu-sheng
Copy link
Contributor

We definitely can support this with tiny changes, after this spec is settled and people can get benefits from these changes.

@mtwo mtwo added this to the Release 0.1.0 milestone Oct 21, 2017
@AloisReitbauer
Copy link
Contributor

This issue is really old. Should we mark it as resolved?

@SergeyKanzhelev
Copy link
Member

Agree needs to be resolved. I'll close it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants