Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header limits are obsolete and should be removed #239

Closed
danielkhan opened this issue Jan 10, 2019 · 7 comments
Closed

Header limits are obsolete and should be removed #239

danielkhan opened this issue Jan 10, 2019 · 7 comments
Assignees
Labels
discuss-next-meeting enhancement The specification works as-is but could be improved.
Milestone

Comments

@danielkhan
Copy link
Contributor

In https://github.com/w3c/trace-context/blame/cr--edit-processing-model/spec/20-HTTP_HEADER_FORMAT.md#L387 we describe the limits which still reflects the 512 character limit we agreed on before coming up with the 5 entry limit.
This is now described in https://github.com/w3c/trace-context/blame/cr--edit-processing-model/spec/20-HTTP_HEADER_FORMAT.md#L375
Should we remove the limits paragraph entirely?

@danielkhan danielkhan added the Editorial The reported issue can be addressed with an editorial change. This tag could be combined with others label Jan 10, 2019
@danielkhan danielkhan self-assigned this Jan 10, 2019
@SergeyKanzhelev
Copy link
Member

Is it possible to close on this item separately from the big CR PR? Few considerations:

@danielkhan
Copy link
Contributor Author

ok - let's discuss that independently of the PR.

@danielkhan danielkhan removed the Editorial The reported issue can be addressed with an editorial change. This tag could be combined with others label Jan 10, 2019
@AloisReitbauer
Copy link
Contributor

AloisReitbauer commented Jan 15, 2019

We cannot move to PR if we do not reach a decision on this topic. I propose we add the trimming procedure to the PR and add a note that size requirements are still under discussion. What is currently in the spec does not reflect the latest discussions, so it at least needs to be removed.

@SergeyKanzhelev SergeyKanzhelev added this to the 4. CR milestone Feb 6, 2019
@SergeyKanzhelev SergeyKanzhelev added the enhancement The specification works as-is but could be improved. label Feb 6, 2019
@SergeyKanzhelev
Copy link
Member

Let's clean up duplicates:

Basically, we need to update rationale document with the logic of
decision and discussions we had. Suggest truncation strategies and
advice on the limits.

I'll close issues above. I'll sent a proposed update for this limit.

@danielkhan
Copy link
Contributor Author

Let's continue discussion in #248

@SergeyKanzhelev
Copy link
Member

@danielkhan can we keep the issue open as it's easier to discover issues left for CR than find a PR with the issue that wasn't closed.

@SergeyKanzhelev
Copy link
Member

closed via #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss-next-meeting enhancement The specification works as-is but could be improved.
Projects
None yet
Development

No branches or pull requests

3 participants