Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenant id format #316

Closed
mwear opened this issue Jul 12, 2019 · 4 comments
Closed

tenant id format #316

mwear opened this issue Jul 12, 2019 · 4 comments

Comments

@mwear
Copy link
Member

mwear commented Jul 12, 2019

The spec indicates that tenant id must begin with lcalpha. I think it will be common for tenant ids to be numeric and for vendors to use numeric ids or a hash of the id. In either case, the resulting id may begin with a number or a string. While this can be worked around, it would be easier for vendors if the tenant id could begin with lcalpha or a DIGIT.

key = lcalpha 0*240( lcalpha / DIGIT / "_" / "-"/ "*" / "/" ) "@" lcalpha 0*13( lcalpha / DIGIT / "_" / "-"/ "*" / "/" )

Is there a reason for restricting identifiers with a tenant_id to starting with lcalphaonly and would allowing them to start with lcalpha or DIGIT be possible?

@danielkhan
Copy link
Contributor

@SergeyKanzhelev - do you have any objections against removing the preceeding lcalpha?

@mtwo
Copy link
Contributor

mtwo commented Jul 23, 2019

SGTM as long as this isn't considered a breaking change

@mwear
Copy link
Member Author

mwear commented Jul 23, 2019

I believe @plehegar said this would be ok because we relaxing the restriction; if went the other direction it would be a problem.

@mwear
Copy link
Member Author

mwear commented Aug 1, 2019

Closing, this was addressed in #322.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants