Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should tracestate list members be truncated when they exceed 32? #440

Closed
MrAlias opened this issue Dec 2, 2020 · 1 comment · Fixed by #448
Closed

How should tracestate list members be truncated when they exceed 32? #440

MrAlias opened this issue Dec 2, 2020 · 1 comment · Fixed by #448
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Dec 2, 2020

The tracestate header field is specified to contain at most 32 list-members. What is the expected behavior when another list-member is added?

Should the truncation schema be used to make room for the new member or is that just the action that needs to be performed when character limits are exceeded?

OpenTelemetry is currently adding support for the tracestate and this question came up there for context.

@dyladan
Copy link
Member

dyladan commented Jan 12, 2021

The spec isn't clear here, but it would make sense to me that the behavior of truncating 128+ character entries first only applies to truncation due to byte size constraint. The 32 list-member limit should just drop the right-most key.

I agree the spec isn't clear here and it should be cleared up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants