Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Relic tracestate identifier #7

Merged
merged 2 commits into from Feb 4, 2021
Merged

Conversation

justinfoote
Copy link
Member

@justinfoote justinfoote commented Jul 28, 2020

Does what it says on the tin.


Preview | Diff

@dyladan
Copy link
Member

dyladan commented Jul 28, 2020

When we fixed the conflicts on #6 we seem to have switched the fields for implementor contact and website. I think we should remove the contact field as it seems nobody wants to use it, and change the format to just be:

| Identifier                             | Implemetation or Company URL                                                                          |
| -------------------------------------- | ----------------------------------------------------------------------------------------------------- |
| `in`                                   | [Instana](https://www.instana.com/)                                                                   |
| `nr`                                   | [New Relic](https://newrelic.com/)                                                                   |

@danielkhan danielkhan merged commit 1ff61b2 into master Feb 4, 2021
@plehegar plehegar deleted the newrelic-tracestate-id branch May 18, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants