Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTWG] CR update for WebVTT #160

Closed
himorin opened this issue Sep 3, 2019 · 5 comments
Closed

[TTWG] CR update for WebVTT #160

himorin opened this issue Sep 3, 2019 · 5 comments
Assignees
Labels
Updating CR Candidate Recommendation Snapshot

Comments

@himorin
Copy link

himorin commented Sep 3, 2019

Link to group's decision to request transition

After CfC for PR ended without resolution, it seems we have agreement after decision on direction. Is it suitable to point an agreement on this?

Link to previous Candidate Recommendation transition request

#126

Substantive changes

  • issue 457, PR 461: Make VTTRegion lines be a long
  • issue 467, PR 470: Update region lines parsing to round to ± MAX_VALUE

Marking followings as at-risk:

  • text-wrap: balance (issue 455)
  • text-combine-upright (issue 456)
  • line alignment
  • position alignment

Diff: https://github.com/gkatsev/webvtt/blob/at-risk-june/archives/2019-09-01/diff.html

Any changes in normative references?

No change

Any changes in requirements?

No change

Wide Review of substantive changes

Substantive changes didn't impact reviews

Issues status

https://github.com/w3c/webvtt/issues

Formal Objections

None

Any changes in implementation information?

Implementation report updated: https://www.w3.org/wiki/TimedText/WebVTT_Implementation_Report
Every one of the failing tests is a browser implementation bug and is fixable. None of these
mean that the spec isn't implementable (as in [5]).

*5 http://lists.w3.org/Archives/Public/public-tt/2019Jun/0003.html
*6 https://lists.w3.org/Archives/Public/public-tt/2019Jun/0033.html

Deadline for further comments

(publication date + 4 weeks)

Any changes in patent disclosures?

None
https://www.w3.org/2004/01/pp-impl/34314/status

(as draft for now; cc @plehegar , @gkatsev )

@himorin himorin added the Updating CR Candidate Recommendation Snapshot label Sep 3, 2019
@himorin himorin self-assigned this Sep 3, 2019
@nigelmegitt
Copy link

@himorin Your link to agreement is to an agreement to merge a pull request, not to publish a CR.

@plehegar plehegar added the [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. label Sep 6, 2019
@swickr
Copy link
Contributor

swickr commented Sep 6, 2019

I'm not convinced this was yet ready for Director review. #460 hasn't been merged so the four issues haven't yet been closed.

@gkatsev
Copy link

gkatsev commented Sep 9, 2019

Yeah, I think this can be closed? @himorin opened this at my behest but there was a misunderstanding on my end about whether the pull request itself was ready vs it being ready to proceed to another CR.

@himorin
Copy link
Author

himorin commented Sep 10, 2019

I'm not convinced this was yet ready for Director review. #460 hasn't been merged so the four issues haven't yet been closed.

Yeah, I think this can be closed? @himorin opened this at my behest but there was a misunderstanding on my end about whether the pull request itself was ready vs it being ready to proceed to another CR.

I can close this for now, actually I was told to open issue with draft request for editing without awaiting director label by @plehegar ...

@plehegar plehegar removed the [DO NOT USE] Awaiting Director Deprecated. Use Awaiting Team Verification. label Sep 11, 2019
@plehegar
Copy link
Member

closing this for now but could be re-opened later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Updating CR Candidate Recommendation Snapshot
Projects
None yet
Development

No branches or pull requests

5 participants