Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAttributeType and getPropertyType should default to HTML namespace, not "" #381

Open
smaug---- opened this issue Dec 4, 2023 · 2 comments
Milestone

Comments

@smaug----
Copy link
Collaborator

Currently the algorithms oddly change empty string to HTML namespace.
That prevents using the methods with elements which are in "" namespace
(whether or not that is actual useful).
But if the methods just defaulted to HTML namespace, then one could still explicitly pass "".

Even better would be to remove both methods, since it is unclear if they are needed.

@koto
Copy link
Member

koto commented Jan 15, 2024

+1 to removing them, after confirming they see no significant enough usage.

@koto koto added the proposed-removal Issues concerning potential removal of functionality from the API label Jan 18, 2024
@mbrodesser-Igalia mbrodesser-Igalia added this to the v1 milestone Jan 23, 2024
@lukewarlow lukewarlow removed the proposed-removal Issues concerning potential removal of functionality from the API label Jan 25, 2024
@lukewarlow
Copy link
Member

lukewarlow commented Jan 25, 2024

Based on discussion in #384 these potentially aren't going to be removed so it would be good to get clarification on the original question

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants