Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can lowercasing be removed from getAttributeType()? #424

Open
annevk opened this issue Jan 25, 2024 · 3 comments
Open

Can lowercasing be removed from getAttributeType()? #424

annevk opened this issue Jan 25, 2024 · 3 comments
Milestone
v1

Comments

@annevk
Copy link
Member

annevk commented Jan 25, 2024

Lowercasing local names is a legacy design error that we should not propagate to new APIs.
@annevk
Copy link
Member Author

annevk commented Jan 25, 2024

This also applies to getPropertyType().

@koto koto added the proposed-removal Issues concerning potential removal of functionality from the API label Jan 25, 2024
@mbrodesser-Igalia mbrodesser-Igalia added this to the v1 milestone Jan 25, 2024
@lukewarlow lukewarlow removed the proposed-removal Issues concerning potential removal of functionality from the API label Jan 25, 2024
@koto koto added the proposed-removal Issues concerning potential removal of functionality from the API label Jan 26, 2024
@lukewarlow lukewarlow removed the proposed-removal Issues concerning potential removal of functionality from the API label Feb 14, 2024
@lukewarlow
Copy link
Member

Based on #384 I'm removing the proposed-removal label

@lukewarlow
Copy link
Member

@koto what are your thoughts on this? Is it likely to cause any compat issues if people are passing through a tag name incorrectly cased and we no longer lowercase it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1
Development

No branches or pull requests
4 participants
@koto @annevk @lukewarlow @mbrodesser-Igalia