-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unspecified font size can't fit a region extent if it's specified in pixels #253
Comments
@fcartegnie in this example, that is correct, since there's no It may be worth using the IMSC tests as a good starting point for implementation testing - I believe those tests are absent this kind of issue (though bugs have a way of finding their way in to any code!). In this specific example, the implementation is expected to allocate some pixel size to the root container region, and at that point you can compute the pixel size of the cell. In other words, the results are different depending on, say, the video, or the video viewport (or whatever else the implementation uses to derive the root container region extent). |
To me that's the same problem. |
Sorry, no, that's not correct - the IMSC Extent002.ttml test specifies the root container region extent as |
@fcartegnie To expand on @nigelmegitt , Makes sense? |
@fcartegnie Looking forward to your feedback on the IMSC tests, by the way. |
I've modifed my code to apply column units to root extents instead of always applying to screen size. |
Anytime! |
ttml1/testsuite/Styling/Origin002.xml
Line 23 in 446dc9b
We have no idea what the 1c font size will finally be and if it will fit the extent.
see also #206
The text was updated successfully, but these errors were encountered: