Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 0271 xml lang metadata examples take 2 #307

Merged
merged 9 commits into from
May 15, 2017

Conversation

nigelmegitt
Copy link
Contributor

2nd take at resolving #271, this time as discussed by adding an example with two ttm:item elements, each with a different xml:lang.

Fix #271 by adding two example `ttm:item` elements, both associated
with an `image`, and each having `name="altText"` and differing
`xml:lang` and text content in the appropriate language.
… note under xml:lang that clarifies that inheritance applies to language identification (#271).
Copy link
Collaborator

@skynavga skynavga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace example with note.

@nigelmegitt
Copy link
Contributor Author

@skynavga I thought from our meeting yesterday that I had this action. In any case I object to removing the example and would like to reinstate it as discussed in order better to illustrate the note you have added.

@skynavga
Copy link
Collaborator

skynavga commented May 12, 2017 via email

@skynavga
Copy link
Collaborator

skynavga commented May 12, 2017 via email

@nigelmegitt
Copy link
Contributor Author

The commenter has already given a hint here, when he added a +1 to the proposal to add a note and an example as per #301 (comment) - nevertheless I'm of course happy to receive further feedback.

I disagree that the new example adds noise; it illustrates the note and therefore makes that note easier to understand. That is the purpose of examples. This is not setting any new precedent. Unless you think that it does not correctly illustrate the note then this seems like a pointless debate; I'm afraid I haven't yet been able to understand why you are so against adding the example @skynavga. By the way just to be clear, I am talking about reinstating the specific short example that only illustrates two ttm:item elements each with differing xml:lang values and content as introduced by 4679535, not the addition of xml:lang to an existing example, which I think we have agreed not to do.

@skynavga
Copy link
Collaborator

skynavga commented May 12, 2017 via email

@skynavga
Copy link
Collaborator

skynavga commented May 12, 2017 via email

@nigelmegitt
Copy link
Contributor Author

@skynavga That would work for me also.

@skynavga
Copy link
Collaborator

Added example in 8.2.8. Decided to leave note in place in 14.1.6.

Copy link
Contributor Author

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. (I cannot explicitly approve this because GitHub thinks it is my pull request)

@skynavga
Copy link
Collaborator

No outstanding substantive comments and 3 days have passed.

@skynavga skynavga deleted the issue-0271-xml-lang-metadata-examples-take-2 branch August 21, 2017 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants