Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel#nextEvent and onCurrentEventChanged missing #33

Open
mprobst-irt opened this issue Nov 17, 2016 · 3 comments
Open

Channel#nextEvent and onCurrentEventChanged missing #33

mprobst-irt opened this issue Nov 17, 2016 · 3 comments

Comments

@mprobst-irt
Copy link

The TVChannel object should have either a nextProperty property or method or currentProgram should return a sequence. In addition an event should be defined which fires when currentProgram changes.

As background, DVB system have EIT p/f which is the current and the next event which can signal the current events on the channel very accurately. They are different to EIT schedule which is the EPG data.

@mprobst-irt
Copy link
Author

any opinion?

@chrisn
Copy link
Member

chrisn commented Dec 5, 2016

I assume you mean nextProgram, rather than nextEvent or nextProperty?

I agree about the need for an event on program change. If this event can only be generated for channels currently being streamed, it would be better for this event to be in an interface more closely related to the TVMediaStream - i.e., the revised TVTuner concept described in #4 (comment) and here - rather than TVChannel.

If we introduce properties to get the current and next programmes, how should these relate to the EPG information available through TVChannel::getPrograms()? Should they be exposed through the revised TVTuner, or from TVChannel?

@mprobst-irt
Copy link
Author

mprobst-irt commented Dec 6, 2016

Nextproperty was a typo

Event comes from EIT.

I am fine with nextprogram and onCurrentProgramChanged

They should be exposed through a tuned channel

edit: e.g. Promise<sequence> TVChannel#getCurrentPrograms()

chrisn asked:

how should these relate to the EPG information available through TVChannel::getPrograms()?

In a DVB deployment this is EIT schedule, getCurrentPrograms EIT p/f
In other deployments they may be identical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants