Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Key event be fired for [Previous] and [Next] key on Virtual Keyboard? #253

Open
makotokato opened this issue Dec 6, 2019 · 3 comments

Comments

@makotokato
Copy link

makotokato commented Dec 6, 2019

Virtual Keyboard sometimes change [ENTER] key with [Done], [Search], [Previous], [Next] and etc on <input> element. See https://developer.android.com/training/keyboard-input/style.html for image.

[Done] and [Search] will fire ENTER key on all browsers (Safari/iOS, Chrome/Android and Firefox/Android). But [Previous] and [Next]'s behaviour is different.

  • Chrome/Android doesn't fire any keyboard event for [Previous] and [Next] (I guess that souce code is here).
  • Firefox/Android emulates as another key ([Next] is TAB key), so it fires keydown as TAB and keyup as TAB.
  • Safari/iOS doesn't change [ENTER] with [Previous] and [Back]. So we can ignore this.

Should Key event be fired for [Previous] and [Next] key on Virtual Keyboard? Or not? If we should fire key event, might we define new key?

@masayuki-nakano
Copy link

@makotokato
Copy link
Author

@dtapuska I guess that enterkeyhint will have same issue. Do you know any reason that Blink doesn't dispatch any key event during Next software key per masayuki's comment.

When GeckoView implements enterkeyhint, I would like to clear this issue.

@dtapuska
Copy link
Contributor

Hmmm.. I thought we specified this but clearly we didn't. Perhaps you can add some additional text to the HTML spec.

When enterkeyhint is set then an 'enter' keydown/keypress/keyup is always dispatched to the target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants