Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check specs are served over https #70

Closed
dontcallmedom opened this issue Dec 5, 2019 · 4 comments
Closed

Check specs are served over https #70

dontcallmedom opened this issue Dec 5, 2019 · 4 comments

Comments

@dontcallmedom
Copy link
Member

dontcallmedom commented Dec 5, 2019 •
edited

https is not enforced as the scheme for github pages created before June 2016 and has to be manually set in the repo settings. We should ensure all relevant repos have that setting enabled.
@foolip
Copy link
Member

foolip commented Dec 12, 2019

I can't see this in https://developer.github.com/v3/repos/pages/ or the GraphQL API. Since it's just few hundred repos, maybe it'd be easiest to just open the right URLs in tabs and go through them all, checking the box where not checked?

@dontcallmedom
Copy link
Member Author

dontcallmedom commented Dec 13, 2019 •
edited

looking a bit more into it, we have 431 repos that were created before the cut-off date according to report.json - that's beyond my motivation :)

I've wrote a little script that instead looks at the repos created before the date and with an homepageUrl set (reducing it to ~230 repos) and testing if the said URL responds with a 301 (which repos set to force-https do). The result is that at least the following repos needs fixing:

(there are probably more since some repos use a non github.io URL for their homepageUrl, and many repos don't set homepageUrl even if they use github pages)

@dontcallmedom
Copy link
Member Author

dontcallmedom commented Dec 13, 2019 •
edited

A more exhaustive look at all repos created before June 2016 and testing if they have a matching github.io URL yields the following list that needs fixing:

@dontcallmedom dontcallmedom mentioned this issue Dec 13, 2019
Closed
13 tasks
@dontcallmedom
Copy link
Member Author

Only one that I couldn't handle myself - raised an issue for it w3ctag/tagdocs#1 ; closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dontcallmedom @foolip