Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that documents that drop data throw errors #131

Closed
msporny opened this issue Jul 28, 2023 · 2 comments
Closed

Ensure that documents that drop data throw errors #131

msporny opened this issue Jul 28, 2023 · 2 comments
Assignees
Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.

Comments

@msporny
Copy link
Member

msporny commented Jul 28, 2023

To ensure JSON compatability, JSON-LD Processors preserve what they can when processing JSON. This can result in some information, that cannot be interpreted given the context provided, being dropped. While this doesn't happen for things using the VC 2.0 context, it can happen if other contexts that don't have a default vocabulary defined are used. JSON-LD processors do create warnings when when things like relative URLs are created or objects are dropped from JSON-LD because they don't have term definitions. We want to ensure that security specifications throw errors when these things happen (when pieces of information would not be signed). Additionally, we want to force the base URL to be null so signing operations on URLs will get same result as someone running it on a document parsed from a URL on the web.

@msporny msporny added ready for pr This issue is ready to be resolved via a pull request before CR This issue needs to be resolved before the Candidate Recommendation phase. labels Jul 28, 2023
@msporny msporny self-assigned this Jul 28, 2023
@msporny
Copy link
Member Author

msporny commented Jul 30, 2023

PR #139 has been raised to address this issue. This issue will be closed once that PR is merged.

@msporny msporny added pr exists A pull request exists to address this issue. and removed ready for pr This issue is ready to be resolved via a pull request labels Jul 30, 2023
@msporny
Copy link
Member Author

msporny commented Aug 12, 2023

PR #139 has been merged, closing.

@msporny msporny closed this as completed Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists A pull request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

1 participant