Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify difference between a verificationMethod in a proof vs. a controller document #187

Closed
msporny opened this issue Aug 29, 2023 · 2 comments
Closed

Clarify difference between a verificationMethod in a proof vs. a controller document #187

msporny opened this issue Aug 29, 2023 · 2 comments
Assignees
@msporny
Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. pr exists A pull request exists to address this issue.

Comments

@msporny
Copy link
Member

msporny commented Aug 29, 2023

@Identitywoman was reviewing the specification and noted that the difference between a "verificationMethod" in proof vs. controller document is confusing.

The one in a proof is a reference to a value (URL) and the one in the controller document is the actual value (object). The specification should be more clear about this distinction.
@msporny msporny added the CR1 This item was processed during the first Candidate Recommendation phase. label Aug 29, 2023
@msporny msporny self-assigned this Aug 29, 2023
@msporny msporny added the ready for pr This issue is ready to be resolved via a pull request label Sep 2, 2023
@msporny msporny added the editorial This issue or PR constitutes an editorial change. label Feb 25, 2024
@msporny msporny mentioned this issue Jun 19, 2024
Merged
@msporny
Copy link
Member Author

msporny commented Jun 19, 2024

PR #269 has been raised to address this issue. This issue will be closed once PR #269 has been merged.

@msporny msporny added pr exists A pull request exists to address this issue. and removed ready for pr This issue is ready to be resolved via a pull request labels Jun 19, 2024
@msporny
Copy link
Member Author

msporny commented Jun 27, 2024

PR #269 has been merged, closing.

@msporny msporny closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
CR1 This item was processed during the first Candidate Recommendation phase. editorial This issue or PR constitutes an editorial change. pr exists A pull request exists to address this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msporny