-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think the diagram key should be changed from Graph Containment
to Contains
#203
Comments
@TallTed I have made the changes on my "core" versions, see https://drive.google.com/drive/folders/1dR194S3hPJZmPNpOcMtXKVMIX2JnwYGZ?usp=sharing If you look at those, you will realize that I went back to black and white. After some experimentation with different dark mode generation styles, bw seems to be the only secure and accessible option. Under some types of dark modes the previous version became unreadable... |
As an aside: keeping these files on a Google Drive may not be the best idea. It is difficult to keep track with the various PR-s involving vocabularies while having a single places to the Google Drive. @msporny, as main manager of these two repositories, would it be o.k. to store the drawio and SVG files in the repo, thereby having different versions? The only annoying aspect is that the generation of the SVG file must be made outside GitHub; I do not think there is a command-line option to generate the SVG file which, due to a current bug in drawio, must go through a separate script anyway. @msporny wdyt? |
@TallTed I hope it is all right that this has been marked as pending close |
Yes, that's fine w/ me. Best to keep source files in the repository. Having to re-generate the SVG isn't great, but I expect we won't need to do that too often. |
After the dust settles, I do not expect much change. I may add a README in the repository's folder to describe what is happening. Next time I raise a PR related to a vocabulary, I will add these. I do not think it is worth raising a PR just for that... |
No objections raised to closing since marked as |
Originally posted by @TallTed and @iherman in #189 (comment)
The text was updated successfully, but these errors were encountered: