Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Relay Attacks" to security considerations #1041

Closed
OR13 opened this issue Feb 14, 2023 · 6 comments
Closed

Add "Relay Attacks" to security considerations #1041

OR13 opened this issue Feb 14, 2023 · 6 comments
Assignees
Labels
blocked holder-binding Issues related to holder binding

Comments

@OR13
Copy link
Contributor

OR13 commented Feb 14, 2023

covering cases where challenges are forwarded / related to holder binding / VPs, etc...

We should describe when relay is legitimate, and where it might cause problems.

relevant attacks on in person presentation, or man in the middle... etc.

@Sakurann Sakurann added the holder-binding Issues related to holder binding label Mar 13, 2023
@OR13
Copy link
Contributor Author

OR13 commented Mar 13, 2023

@awoie awoie self-assigned this Apr 5, 2023
@awoie
Copy link
Contributor

awoie commented Apr 12, 2023

IMO, we cannot say when relay is legitimate. We can only point out under which circumstances relay can happen and what verifiers can do to mitigate that risk. I suggest, after we merge PR #1054, we extend the security considerations section to add some language around relay.

@awoie
Copy link
Contributor

awoie commented Apr 25, 2023

This issue is blocked by the holder binding discussion. It really depends on whether such a feature is available. It makes a difference for the security consideration section whether a VC has some protection against impersonation or not.

@awoie awoie added the blocked label Apr 25, 2023
@OR13
Copy link
Contributor Author

OR13 commented May 4, 2023

Closing this issue, I think it is not addressable in the core data model, it applies to securing formats.

@OR13 OR13 closed this as completed May 4, 2023
@TallTed
Copy link
Member

TallTed commented May 8, 2023

Closing this issue, I think it is not addressable in the core data model, it applies to securing formats.

You opened this as a Security Consideration, which it remains, and which does not require addressing in the core data model — Security Considerations are about awareness and consideration regarding whatever deployment...

So I don't understand its closure, as opposed to adding a few sentences to the Security Considerations section.

@OR13
Copy link
Contributor Author

OR13 commented May 9, 2023

@TallTed you are welcome to raise a new issue or file a PR that implements changes you want to see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked holder-binding Issues related to holder binding
Projects
None yet
Development

No branches or pull requests

4 participants