Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to DocumentVerification2018 #1124

Closed
OR13 opened this issue May 9, 2023 · 3 comments · Fixed by #1170
Closed

Remove reference to DocumentVerification2018 #1124

OR13 opened this issue May 9, 2023 · 3 comments · Fixed by #1170
Labels
pr exists

Comments

@OR13
Copy link
Contributor

OR13 commented May 9, 2023

This RDF Class was never defined and is confusing:

https://github.com/search?q=repo%3Aw3c%2Fvc-data-model%20DocumentVerification2018&type=code
@brentzundel
Copy link
Member

I agree that this reference should be fixed (if evidence ends up being retained) or removed.

@TallTed
Copy link
Member

TallTed commented Jun 22, 2023

This issue should be retitled to reflect that the referenced RDF Class is not 20DocumentVerification2018, but DocumentVerification2018. (The %20 in the URL is a URL-escaped space in the GitHub search term.)

@Sakurann
Copy link
Contributor

+1 to remove.

@Sakurann Sakurann added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Jun 22, 2023
@brentzundel brentzundel changed the title Remove reference to 20DocumentVerification2018 Remove reference to DocumentVerification2018 Jun 23, 2023
@brentzundel brentzundel mentioned this issue Jun 26, 2023
Merged
@brentzundel brentzundel added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pr exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update example types brentzundel/vc-data-model
4 participants
@TallTed @OR13 @brentzundel @Sakurann