Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Security Consideration to avoid key reuse #1284

Closed
msporny opened this issue Aug 18, 2023 · 7 comments
Closed

Add Security Consideration to avoid key reuse #1284

msporny opened this issue Aug 18, 2023 · 7 comments
Assignees
Labels
before-CR pr exists security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.

Comments

@msporny
Copy link
Member

msporny commented Aug 18, 2023

From the PING's review (w3cping/privacy-request#120):

Security section should make mention of key reuse considerations and the impact of reusing a key for multiple algorithms. While some combinations of algorithms have proofs that it's sufficiently secure to reuse keys for various algorithms many do not. This spec should discourage the reuse of keys whenever possible to prevent cryptography attacks that could reveal the private key.

/cc @kdenhartog

@msporny
Copy link
Member Author

msporny commented Aug 18, 2023

We should also reference this paper in the guidance: https://eprint.iacr.org/2021/509

@msporny msporny added the security-needs-resolution Issue the security Group has raised and looks for a response on. label Aug 19, 2023
@msporny
Copy link
Member Author

msporny commented Aug 19, 2023

Hrm, turns out that we do provide this guidance in the ECDSA Cryptosuite, so perhaps we should move that guidance to the main Data Integrity spec: https://www.w3.org/TR/2023/WD-vc-di-ecdsa-20230817/#key-management

@Wind4Greg
Copy link
Contributor

I added that section, based on NIST and general recommendations. It is very general. So moving it to Data Integrity sounds good and avoids repetition in EdDSA, and future specs.

@kdenhartog
Copy link
Member

I'd even suggest pushing up to the vc-data-model spec. While this issue is more commonly encountered in data-integrity formats from did:key it's an issue that re-applies across the entire space.

@msporny msporny added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Sep 15, 2023
@msporny msporny self-assigned this Sep 15, 2023
@msporny
Copy link
Member Author

msporny commented Sep 15, 2023

Agreed, this belongs in the vc-data-model as a general consideration regarding key re-use in any securing mechanism.

@msporny msporny transferred this issue from w3c/vc-data-integrity Sep 15, 2023
@msporny
Copy link
Member Author

msporny commented Oct 21, 2023

PR #1323 has been raised to address this issue. This issue will be closed once PR #1323 has been merged.

@msporny msporny added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Oct 21, 2023
@msporny
Copy link
Member Author

msporny commented Nov 4, 2023

PR #1323 has been merged, closing.

@msporny msporny closed this as completed Nov 4, 2023
@plehegar plehegar added privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. and removed security-needs-resolution Issue the security Group has raised and looks for a response on. labels Nov 10, 2023
@w3cbot w3cbot added security-needs-resolution Issue the security Group has raised and looks for a response on. and removed security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. labels Jan 28, 2024
@plehegar plehegar added security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response. and removed security-needs-resolution Issue the security Group has raised and looks for a response on. privacy-tracker Group bringing to attention of Privacy, or tracked by the Privacy Group but not needing response. labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before-CR pr exists security-tracker Group bringing to attention of security, or tracked by the security Group but not needing response.
Projects
None yet
Development

No branches or pull requests

5 participants