Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifying a VC should return the same credential regardless of the verification method #1399

Closed
David-Chadwick opened this issue Dec 20, 2023 · 3 comments

Comments

@David-Chadwick
Copy link
Contributor

Our Data Model is that we have a credential, and by adding a proof (external or embedded) we get a verifiable credential. Conversely after verifying a VC, the credential that is returned should be identical regardless of the proofing mechanism

@selfissued
Copy link
Contributor

David is correct. This logic needs to be applied to the ambiguous text in #1393 before it can be merged.

@dlongley
Copy link
Contributor

A credential with a proof field does not "unbecome" a credential, it is just both a credential and a verifiable credential. However, I would be supportive of allowing both of these options to be returned from an "embedded proof" securing mechanism to enable users of either approach.

@msporny
Copy link
Member

msporny commented Dec 26, 2023

Conversely after verifying a VC, the credential that is returned should be identical regardless of the proofing mechanism

This was done in PR #1393, commit 8c16fec. Specifically, the text now says:

Securing mechanism specifications MUST provide a verification mechanism that returns only the information in the conforming document that has been secured, without any securing mechanism information included, such as proof or JOSE/COSE metadata. Specifications MAY provide additional mechanisms to convey other information that might be helpful (for example, during validation or for debugging purposes), such as securing mechanism metadata.

This issue is now addressed in the latest version of the specification, closing.

@msporny msporny closed this as completed Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants