Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The confusing nature of type and presentation #653

Closed
brentzundel opened this issue May 28, 2019 · 2 comments
Closed

The confusing nature of type and presentation #653

brentzundel opened this issue May 28, 2019 · 2 comments
Labels
pending close Close if no objection within 7 days post cr comment period Submitted after the end of the CR review period, if an external issue this may not be addressed. pr exists

Comments

@brentzundel
Copy link
Member

The text in the spec is unclear about whether it is required for presentations and encapsulated objects to have multiple types. My understanding is that the type field for a verifiable credential MUST have more than one type, but that presentations, encapsulated objects, etc. do not have this requirement.
I recommend text be added to clarify that while type is required for presentations and encapsulated objects, it is not required for those objects to have multiple types. Examples in the spec should also be changed to reflect this.

Related to issue #600
@brentzundel brentzundel added the post cr comment period Submitted after the end of the CR review period, if an external issue this may not be addressed. label May 28, 2019
@brentzundel brentzundel mentioned this issue Jun 5, 2019
Merged
@burnburn
Copy link
Contributor

From the VCWG call on 11 June 2019:

RESOLUTION: Merge PR #658 as it reflects the consensus of the Working Group. Specifically, more organizations would object to more stringent type requirements than what exists in PR 658.
[10:37] manu: I'll merge that as soon as Brent makes the minor change
[10:38] burn: that resolution only applies after a change has been made.

@msporny msporny mentioned this issue Jun 30, 2019
Closed
@msporny msporny added the pending close Close if no objection within 7 days label Jun 30, 2019
@msporny
Copy link
Member

msporny commented Jul 9, 2019

The minor change was made in 12681f9 and was merged into the specification 9 days ago. Please close.

@burnburn burnburn closed this as completed Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending close Close if no objection within 7 days post cr comment period Submitted after the end of the CR review period, if an external issue this may not be addressed. pr exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@msporny @burnburn @brentzundel