Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing context in an example? #871

Closed
iherman opened this issue Feb 15, 2022 · 2 comments
Closed

Missing context in an example? #871

iherman opened this issue Feb 15, 2022 · 2 comments
Labels
editorial Purely editorial changes to the specification. ready for PR This issue is ready for a Pull Request to be created to resolve it

Comments

@iherman
Copy link
Member

iherman commented Feb 15, 2022

Looking at the examples in the chapter on extensibility in the Editors' draft. Example 15 starts with

{
    "@context ": [
        "https://www.w3.org/2018/credentials/v1",
        "https://www.w3.org/2018/credentials/examples/v1",
        "https://w3id.org/security/suites/ed25519-2020/v1"
    ],
}

The text then explains how one can create a new context file and this leads to Example 17 that starts with

{
    "@context": [
        "https://www.w3.org/2018/credentials/v1",
        "https://example.com/contexts/mycontext.jsonld"
    ],
}

The two context files .../examples/v1 and .../ed25519-2020/v1 are missing. One could explain the latter, because Example 17 does not include a proof section (although in my view it should, for the sake of completeness), but the former is definitely missing.

@msporny
Copy link
Member

msporny commented Jun 11, 2022

Agree that this should be fixed.

@msporny msporny added the v2.0 label Jun 11, 2022
@msporny msporny self-assigned this Jun 11, 2022
@Sakurann Sakurann added editorial Purely editorial changes to the specification. and removed v2.0 labels Jul 28, 2022
@msporny msporny added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Oct 22, 2022
@msporny msporny removed their assignment Oct 26, 2022
@msporny
Copy link
Member

msporny commented Dec 11, 2022

Fixed in dced606, closing.

@msporny msporny closed this as completed Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification. ready for PR This issue is ready for a Pull Request to be created to resolve it
Projects
None yet
Development

No branches or pull requests

3 participants