Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normative reference to Data Integrity #912

Closed
Sebastian-Elfors-IDnow opened this issue Aug 18, 2022 · 4 comments
Closed

Add normative reference to Data Integrity #912

Sebastian-Elfors-IDnow opened this issue Aug 18, 2022 · 4 comments
Labels
editorial Purely editorial changes to the specification. pr exists

Comments

@Sebastian-Elfors-IDnow
Copy link

In section "A.4 Proofs (Signatures)" in the W3C Verifiable Credentials Data Model v2.0 draft, there is a description of Linked Data Signatures in the Note:

"For example, a Linked Data Signature created property establishes a date and time before which the credential should not be considered verified."

However, there is no definition nor reference to the Linked Data Signatures in the W3C VC v2.0 draft.

Furthermore, the Linked Data Proofs specification does not exist anymore at either the https://w3c.github.io/data-integrity/ nor https://w3c-dvcg.github.io/ld-proofs/.

It could make sense to specify Linked Data Proofs in a separate standard and then refer to this from W3C VC v2.0 - or in the lack of such Linked Data Proofs standard remove the description of Linked Data Signatures from the W3C VC v2.0 draft.

@Sakurann
Copy link
Contributor

The work on Linked Data Proofs specification continues as Data Integrity specification. We should probably change all the references to LDPs in the v2 to Data Integrity and add a note explaining this difference.
(Might be good to have a section in v2 that summarizes "what is different in v2 from v1")

@decentralgabe decentralgabe added editorial Purely editorial changes to the specification. data-integrity? labels Sep 9, 2022
@msporny msporny changed the title Linked Data Signature reference is missing Add normative reference to Data Integrity Oct 22, 2022
@msporny
Copy link
Member

msporny commented Oct 22, 2022

We need to add a normative reference to the Data Integrity specification from the VC Data Model specification. This issue is ready for a PR.

@msporny msporny added the ready for PR This issue is ready for a Pull Request to be created to resolve it label Oct 22, 2022
@msporny msporny assigned msporny and unassigned msporny Oct 22, 2022
@msporny
Copy link
Member

msporny commented Dec 11, 2022

PR #993 has been raised to address this issue. This issue will be closed once PR #993 is merged.

@msporny msporny added pr exists and removed ready for PR This issue is ready for a Pull Request to be created to resolve it labels Dec 11, 2022
@msporny
Copy link
Member

msporny commented Jan 24, 2023

PR #993 has been merged, closing.

@msporny msporny closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification. pr exists
Projects
None yet
Development

No branches or pull requests

4 participants