Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature/proof formats are undocumented #61

Closed
andrewwhitehead opened this issue Aug 4, 2021 · 4 comments
Closed

Signature/proof formats are undocumented #61

andrewwhitehead opened this issue Aug 4, 2021 · 4 comments
Assignees
Labels
pending-close The issue will be closed in 7 days if there are no objections.

Comments

@andrewwhitehead
Copy link

Unless I've missed it, neither this specification nor the BBS+ signatures spec defines the encoding for a BBS+ signature or for a PoK of a signature. The signature is fairly simple, although the compression and endianness need to be explicit. The proof encoding is rather more complicated.

@OR13
Copy link
Contributor

OR13 commented Oct 4, 2021

@andrewwhitehead you are correct, and a recent bug in this highlights why its important, the correct place is not here though, its the DIF WG that manages the definition for BBS+.

@andrewwhitehead
Copy link
Author

Yup, related issue: decentralized-identity/bbs-signature#2

@OR13
Copy link
Contributor

OR13 commented Apr 25, 2023

This is still critical to fix, the document needs to be pointed to the latest IETF drafts.

@OR13 OR13 added the critical label Apr 25, 2023
@OR13 OR13 self-assigned this May 1, 2023
@OR13 OR13 mentioned this issue May 1, 2023
@Wind4Greg
Copy link
Collaborator

Updated document contains full definitions of signature and proof formats along with test vectors.

@Wind4Greg Wind4Greg added pending-close The issue will be closed in 7 days if there are no objections. and removed critical labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-close The issue will be closed in 7 days if there are no objections.
Projects
None yet
Development

No branches or pull requests

3 participants