Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example rendering for JOSE / COSE #240

Closed
decentralgabe opened this issue Feb 20, 2024 · 3 comments · Fixed by #241
Closed

Update example rendering for JOSE / COSE #240

decentralgabe opened this issue Feb 20, 2024 · 3 comments · Fixed by #241
Assignees
@decentralgabe
Labels
before-CR editorial Editorial changes only has-pr

Comments

@decentralgabe
Copy link
Collaborator

decentralgabe commented Feb 20, 2024 •
edited
Loading 

          I suggest that the Disclosed tab should be renamed to Credential and be the first tab in the set, since this appears to be the raw credential before it undergoes any processing

Originally posted by @David-Chadwick in #237 (review)

Also the verified tab should correctly display enveloped credentials as per @iherman's comment here #239 (comment)
@decentralgabe decentralgabe self-assigned this Feb 20, 2024
@decentralgabe decentralgabe added post-CR editorial Editorial changes only labels Feb 20, 2024
@decentralgabe decentralgabe mentioned this issue Feb 20, 2024
Merged
@decentralgabe
Copy link
Collaborator Author

@David-Chadwick this should be fixed by uptaking @OR13's change set here transmute-industries/respec-vc-jwt#5 which supports examples for more than SD-JWT.

I will make sure this gets done.

@decentralgabe decentralgabe mentioned this issue Feb 20, 2024
Closed
@decentralgabe decentralgabe changed the title Examples: renamed Disclosed tabto Credential Examples: renamed Disclosed tab to Credential Feb 20, 2024
@decentralgabe
Copy link
Collaborator Author

flagging there are some comments from @TallTed here that I will include in this change set.

@decentralgabe decentralgabe changed the title Examples: renamed Disclosed tab to Credential Update example rendering for JOSE / COSE Feb 20, 2024
@decentralgabe decentralgabe mentioned this issue Feb 20, 2024
Merged
@David-Chadwick
Copy link
Contributor

Thanks. Looking forward to reviewing the PR

@decentralgabe decentralgabe linked a pull request Feb 21, 2024 that will close this issue
Update plugin to pull in COSE, JWT, and SD-JWT rendering #241
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decentralgabe decentralgabe

Labels
before-CR editorial Editorial changes only has-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update plugin to pull in COSE, JWT, and SD-JWT rendering w3c/vc-jose-cose
2 participants
@David-Chadwick @decentralgabe