Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guidance on collisions between VC property names and registered JWT claims #98

Closed
andresuribe87 opened this issue May 31, 2023 · 5 comments
Closed

Guidance on collisions between VC property names and registered JWT claims #98

andresuribe87 opened this issue May 31, 2023 · 5 comments
Labels
blocked-by-vc-data-model

Comments

@andresuribe87
Copy link
Contributor

Imagine that we start with the core VCDM (i.e. application/vc+ld+json) and want to secure it according to Section 3 (Securing the Core VC Data Model). The VCDM may have additional property fields defined by the issuer (for the sake of this example, let's say the issuer populated a verified_claims property). If interpreted as a JWT, the claim who's name is verified_claims was registered in this spec.

What's the guidance on conflicting JWT Claim names and VC property names when securing the core VCDM?

Personally, I think we should be wrapping the VCDM inside the vc registered claim; but it seems like we've moved in a different direction.
@andresuribe87 andresuribe87 mentioned this issue Jun 9, 2023
Merged
@OR13
Copy link
Contributor

OR13 commented Jun 27, 2023

I think this has been addressed in recent PRs.

@OR13
Copy link
Contributor

OR13 commented Jun 27, 2023

If the problem remains, it needs to be solved here: w3c/vc-data-model#1149

@Sakurann
Copy link
Contributor

Sakurann commented Sep 9, 2023

1149 in vcdm was merged and afaik there are no collision in vc property names and registered jwt claims anymore :)

@Sakurann Sakurann closed this as completed Sep 9, 2023
@Sakurann
Copy link
Contributor

Sakurann commented Sep 9, 2023

1149 in vcdm was merged and afaik there are no collision in vc property names and registered jwt claims anymore :)

1 similar comment
@Sakurann
Copy link
Contributor

Sakurann commented Sep 9, 2023

1149 in vcdm was merged and afaik there are no collision in vc property names and registered jwt claims anymore :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-by-vc-data-model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andresuribe87 @OR13 @Sakurann