Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe why core data model members are translated to JWT claims #15

Closed
OR13 opened this issue Sep 15, 2022 · 7 comments
Closed

Describe why core data model members are translated to JWT claims #15

OR13 opened this issue Sep 15, 2022 · 7 comments

Comments

@OR13
Copy link
Contributor

OR13 commented Sep 15, 2022

Can we add an explanation why do these members need to be translated to the equivalents of the JWT claims?
iss, nbf, all of them are optional in RFC 7519 itself. They only become required when the JWT is used for a specific purpose, and the only place I can think of right now is an ID Token.

See: #11 (comment)

@TallTed

This comment was marked as resolved.

@OR13 OR13 changed the title Describe my core data model members are translated to JWT claims Describe why core data model members are translated to JWT claims Sep 15, 2022
@selfissued
Copy link
Collaborator

The "iss", "iat", and "exp" claims are required in most secure profiles of JWTs. We should do the same.

Likewise, "kid" is typically a required header parameter (as of course, is "alg").

@OR13
Copy link
Contributor Author

OR13 commented Oct 14, 2022

I am a +1 to making iat explicitly required...

I am a -1 to making exp required (core data model does not require it so this isn't the right place to argue that anyway).

iss is already required by the core data model.

@OR13
Copy link
Contributor Author

OR13 commented Jun 30, 2023

This can be closed when #88 is merged

@OR13
Copy link
Contributor Author

OR13 commented Jul 19, 2023

@selfissued still blocked by #88

@TallTed
Copy link
Member

TallTed commented Jul 19, 2023

[@OR13] blocked by the same PR

Does this refer to #88?

Please refer to PRs and Issues by link/number, rather than indefinite things like "same PR".

@Sakurann
Copy link
Contributor

Sakurann commented Sep 7, 2023

#88 was merged

@Sakurann Sakurann closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants