-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add key discovery example #122
Conversation
@@ -388,7 +388,6 @@ <h2>Key Discovery</h2> | |||
<p class="issue" data-number="31"></p> | |||
<p class="issue" data-number="30"></p> | |||
<p class="issue" data-number="15"></p> | |||
<p class="issue" data-number="13"></p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue marker plugin imports input
tags... which then break validation... also... seems dangerous to be importing input
tags from an issue tracker...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the issue marker plugin imports
input
tags... which then break validation... also... seems dangerous to be importinginput
tags from an issue tracker...
It seems like this should be raised as an issue on the issue marker plugin, rather than a comment within a PR (which will persist somewhere, but may be generally invisible, after the PR is merged)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not trying to contribute to echidna or respec.
I'm explaining why the commits for this PR were failing for reasons unrelated to the changes in the PR.
You are welcome to cross link to this, if find the right repo and want to help them fix this bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not trying to contribute to echidna or respec.
Go, team spirit!
I'm explaining why the commits for this PR were failing for reasons unrelated to the changes in the PR.
Usually, that would lead me to report an issue on the component that was causing me a headache, whether or not I could provide further input toward resolving that issue. Often, others chime in with "I hit that, too" or "here's how I worked around that" or "I've created a PR with a potential fix".
You are welcome to cross link to this, if find the right repo and want to help them fix this bug.
@msporny @iherman — Does either of you know the repo for the issue marker plugin?
I do not know enough about what was going wrong to usefully report the issue there, but perhaps if the repo becomes known, @OR13 will find a few minutes to log the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed I pay membership fees to to W3C... I also volunteer a lot of time... but I also agree with your team spirit comment... I think...
I'm worse at what I do best
And for this gift, I feel blessed
Our little group has always been
And always will until the end
- Nirvana
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
@TallTed excellent suggestions as always. Thank you! |
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change OIDC -> OpenID Connect before merging.
Preview | Diff