Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPWD #74

Merged
merged 4 commits into from
Apr 17, 2023
Merged

FPWD #74

merged 4 commits into from
Apr 17, 2023

Conversation

OR13
Copy link
Contributor

@OR13 OR13 commented Apr 14, 2023

Prepare FPWD


Preview | Diff

@@ -1052,13 +1052,13 @@ <h2>Example Mapping</h2>
If <code>nbf</code> is present, set the value of <code>validFrom</code> to the
<code>dateTime</code> obtained by converting the value of <code>nbf</code> from
the <code>NumericDate</code> described in [[!RFC7519]] to a <code>dateTime</code> as
described in [[!XMLSCHEMA11-2]].
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing a respec warning.

Copy link
Collaborator

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iherman iherman self-requested a review April 15, 2023 09:47
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my mail on the list the publication date of the 20th does not work. The date should be changed to the 25th or the 27th, depending on the WG resolution

@OR13
Copy link
Contributor Author

OR13 commented Apr 15, 2023

Screen Shot 2023-04-15 at 8 07 23 AM

Screen Shot 2023-04-15 at 8 03 59 AM

@OR13 OR13 requested a review from iherman April 15, 2023 13:08
@OR13
Copy link
Contributor Author

OR13 commented Apr 15, 2023

I have updated the publication date to the 27th per the request on the list.

@iherman I have also attached screenshots:

Link Check Tool

  • Errors on IANA (can't fix this)
  • complains about non existing URLs (as expected)

Pub Rules

  • No Errors

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OR13. B.t.w., there is no bug in the link checker: the three links are, indeed, missing at this moment, but they will fall in place as part of the publication process. Actually, the FPWD has already been published, so the second error is already moot.

The official request for publication has gone out: w3c/transitions#500 and, as far as I am concerned, this PR can be merged for historical purposes.

@OR13
Copy link
Contributor Author

OR13 commented Apr 17, 2023

@brentzundel @Sakurann can I merge this PR?

@brentzundel
Copy link
Member

I support merging based on Ivan's comment above.

@Sakurann
Copy link
Contributor

Please merge

@OR13
Copy link
Contributor Author

OR13 commented Apr 17, 2023

I am merging at the direction of our chairs and our staff contact.

@OR13 OR13 merged commit 5e5b103 into main Apr 17, 2023
@OR13 OR13 deleted the fpwd branch June 7, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants