Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success criteria ??? #58

Closed
samuelweiler opened this issue Jan 27, 2022 · 2 comments · Fixed by #49
Closed

Success criteria ??? #58

samuelweiler opened this issue Jan 27, 2022 · 2 comments · Fixed by #49
Labels
security-needs-resolution Issue the security Group has raised and looks for a response on.

Comments

@samuelweiler
Copy link
Member

The group will there ....

It looks like you rewrote the boilerplate from the charter template.

Whenever that happens, I wonder why we're not seeing a PR back to the template - if the template needs to be improved, let's improve it.

Meanwhile, the rewrite is ungrammatical.

@samuelweiler samuelweiler added the security-needs-resolution Issue the security Group has raised and looks for a response on. label Jan 27, 2022
@iherman
Copy link
Member

iherman commented Jan 28, 2022

@samuelweiler, coincidentally, I synced with the latest template (including the success criteria section) a few days ago, see #49. Could you look at, and comment, on that PR to see if it is o.k.?

For the specifics: that PR took over the boiler-plate section for the success criteria recently, see #49 (comment)

@samuelweiler
Copy link
Member Author

#49 fixes this issue.

@iherman iherman linked a pull request Jan 28, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-needs-resolution Issue the security Group has raised and looks for a response on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants