Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Koblitz ECDSA Recovery Cryptosuite #105

Merged
merged 1 commit into from Mar 30, 2022

Conversation

clehner
Copy link
Member

@clehner clehner commented Mar 23, 2022

I'd like to offer this cryptosuite for recoverable ECDSA signatures as a possible input document in the purview of the WG: https://github.com/decentralized-identity/EcdsaSecp256k1RecoverySignature2020

The "Public Key Recovery Operation" is described in section 4.1.6 of SEC 1 v2.0.

Sorry this is a bit late.


Preview | Diff

@OR13
Copy link
Contributor

OR13 commented Mar 23, 2022

This PR addresses a use case we have been contributing to for years, and is very much welcome... ES256K-R was originally invented by UPort, marketed as a solution for VC-JWT, but never registered with IANA or IETF.... This PR addresses that historical context and opens the door to encourage WG members to resolve these issues.

@mprorock
Copy link
Contributor

Very important for us as well

@brianorwhatever
Copy link

yes, a very important signature suite lets get this in

@mirceanis
Copy link

Many thanks for this @clehner!
We should have done this years ago :)

@brentzundel brentzundel merged commit a983540 into w3c:main Mar 30, 2022
@iherman
Copy link
Member

iherman commented Mar 31, 2022

The issue was discussed in a meeting on 2022-03-30

  • no resolutions were taken
View the transcript

1.1. Add Koblitz ECDSA Recovery Cryptosuite (pr vc-wg-charter#105)

See github pull request vc-wg-charter#105.

Brent Zundel: This was raised by cel , can you talk us through it. (Charles Lehner).

Charles Lehner: This adds Koblitz ECDSA Recovery Cryptosuite.
… It's similar to other mentioned suites for other algorithms.
… It's JWS based with detached mode. Incorporates new unregistered JWA. This is at DIF.

Michael Prorock: See EcdsaSecp256k1RecoverySignature2020.

Manu Sporny: +1 to this. Supportive of this.
… At some point we need to understand by which DIF releases these specs, so that this WG can pick it up and use it.
… I hope the group that creates it operates in W3C mode, not sure if we have ever handed over a spec from DIF.

Manu Sporny: I don't anticipate it being a problem either, we just need to have an answer for W3C legal.

Brent Zundel: There is an Apache license on the repo. I agree we need to interact with DIF to more formally handle it. I don't anticipate a problem considering the license.
… This PR had positive feedback. Anyone opposed to merging it?
… Hearing no opposition, will merge it.

@sbihel sbihel deleted the secp256k1recovery branch April 29, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants