Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Core Ontology: StaticVehicleAttributes: which attributes shall be explicit? #9

Open
danielwilms opened this issue Feb 10, 2021 · 6 comments

Comments

@danielwilms
Copy link
Contributor

Static vehicle attributes define the vehicle and are set in the core ontology #5 as datatype properties. Question is, if and which attributes are better to be modelled as explicit classes instead of properties. Any Opinion?

@danielwilms danielwilms added the help wanted Extra attention is needed label Feb 10, 2021
@danielwilms danielwilms changed the title StaticVehicleAttributes: which attributes shall be explicit? Proposal Core Ontology: StaticVehicleAttributes: which attributes shall be explicit? Feb 13, 2021
@danielwilms danielwilms removed the help wanted Extra attention is needed label Feb 13, 2021
@jdacoello
Copy link

Considering that the class Vehicle is the main concept of VSSo, I like all the vehicle static attributes as literals connected with the relationship hasStaticVehicleProperty and its sub properties like hasVehicleIdentificationVIN.

However, if you want to tell something else about such attributes (e.g., that the static attribute belongs to a particular component of the vehicle), then I would model those as subclasses of StaticVehicleProperty. One general approach could be to keep all identification attributes (e.g., VIN) or anything that is part of a virtual vehicle component as literals connected via data properties.

@danielwilms
Copy link
Contributor Author

Here is a proposal using sub-classes for static vehicle properties:
vsso modeling-static

The generated ttl file will be attached as soon, as it's ready.

@jdacoello
Copy link

It seems to me that we can remove the owl:AnnotationProperty. Or is it adding something relevant in practice?
In the end, now both (vsso:StaticVehicleProperty and vsso:DynamicVehicleProperty) are conected to a particular VehicleComponent via the vsso:belongsToVehicleComponent relationship.

@danielwilms
Copy link
Contributor Author

It seems to me that we can remove the owl:AnnotationProperty. Or is it adding something relevant in practice?
In the end, now both (vsso:StaticVehicleProperty and vsso:DynamicVehicleProperty) are conected to a particular VehicleComponent via the vsso:belongsToVehicleComponent relationship.

I would keep focussing on the staticVehicleProperty here. Please use #8 for that discussion.

@felix-loesch
Copy link

Considering that the class Vehicle is the main concept of VSSo, I like all the vehicle static attributes as literals connected with the relationship hasStaticVehicleProperty and its sub properties like hasVehicleIdentificationVIN.

However, if you want to tell something else about such attributes (e.g., that the static attribute belongs to a particular component of the vehicle), then I would model those as subclasses of StaticVehicleProperty. One general approach could be to keep all identification attributes (e.g., VIN) or anything that is part of a virtual vehicle component as literals connected via data properties.

We (Felix, Anees from Bosch) discussed this with @danielwilms and agreed on taking the latter choice, i.e., modelling static attributes (e.g. number of cabin doors) as sub-classes of StaticVehicleProperty. That way these properties can be connected to VehicleComponent using belongsToVehicleComponent.

@felix-loesch
Copy link

Contrary to my comment from Apr 29, I suggest to model static attributes as instances of StaticVehicleProperty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants