New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main menu does not render correctly after using “Make text bigger” option in desktop Safari #389
Comments
Indeed, the menu appears correctly only after decreasing the size of the window. @NicolaSaunders it looks like the mediaqueries values don't match the default breakpoint on safari... |
This appears to be a long-standing Safari bug. Zooming the entire page (using [command] [+] keys) the CSS media queries (using the This JSFiddle also illustrates the problem: https://jsfiddle.net/raubx6p7/ The same behaviour can be seen on other major websites in Safari when zooming the text only rather than zooming the entire page. |
I’m not sure that’s the correct bug. That bug is about I’ve tested your jsfiddle. It seems that ”Make text bigger” does not update The question is, should It have actually thought about this before, and my theory is that Safari adjusts the used Screen.Recording.2023-06-23.at.16.03.11.mov |
Well, I'm definitely not an expert on the processing of CSS values! So I cannot comment on your theory.
That's true. In Chrome the options for increasing font size via Settings are limited (with options for "Large" and "Very large") but doing so still does not cause the same problems that you have spotted in Safari. The same is true of Firefox (which offers a broader range of font size options). |
Yes, changing the default font size in Chrome and Firefox does affect the value of I suspect that Apple’s goal with “Make text bigger” was to really only make the text bigger and affect nothing else, and that’s why they decided to keep |
Are you happy if we close this issue now? |
I don’t think this issue should be closed. I suspect that Apple’s view is that “Make text bigger” works as intended. That would mean that the issue with the menu on w3.org would need to be fixed by the website, if that’s possible. If that’s not possible, than that needs to be reported to Apple. |
cc: @svgeesus who might have some guidance on how to address this problem. |
I don't really agree with Apple's reasoning here but agree that they see it as intended behavior; so they won't fix it in Safari. So if we want to work around this, it needs to be on our side. |
@simevidas wrote:
and @svgeesus wrote:
Is there a particular statement of reasoning from another Apple rep you're referencing? I suspect it's just a WebKit bug limited to Media Queries. Case in point: main {
width: 800px;
min-width: 25em;
} …so if there was an ulterior motive for preventing |
In an earlier comment I said that “Make text bigger” (MTB) does not change the value of After some more testing, I observed that MTB does increase the value of So the fact that MTB changes the value of Test page: https://output.jsbin.com/gacohuy/quiet (resize the viewport before/after using MTB) [command] [option] [+] = Make text bigger |
Thanks everybody. I personally still think it is related to https://bugs.webkit.org/show_bug.cgi?id=41063. Please can somebody confirm whether they are happy to pass on all the details to the the Apple/safari team, and whether this issue can be closed as it will not be resolved on our side? |
I’ve filed a new WebKit bug here: https://bugs.webkit.org/show_bug.cgi?id=258619 I think this issue can be closed now. |
Thank you very much @simevidas - I am now closing this issue. |
Steps to reproduce:
Notice how the main menu does not render correctly in this video:
Screen.Recording.2023-06-22.at.16.11.45.mov
The text was updated successfully, but these errors were encountered: