Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redesign] Improve visual design for “Add more of type“ functionality #370

Closed
hidde opened this issue Feb 9, 2021 · 6 comments
Closed

Comments

@hidde
Copy link
Member

hidde commented Feb 9, 2021

Some parts of the WCAG EM Report Tool allow the user to add more of a certain time. for instance, “Add sample”, which adds a set of fields (URI, description) for a sample.

This issue is to improve the visual design for this component and potentially add it to the WAI Design Components.

cc @slhenry @nitedog

Screenshot 2021-02-09 at 15 46 19

@nitedog
Copy link
Contributor

nitedog commented Feb 11, 2021

I like how "Address" and "Short name" appear on the same line (on most configurations) in the current design. I think it makes it less daunting and contextually easier to understand.

@hidde hidde modified the milestones: 26 March, 16 April Mar 24, 2021
@hidde
Copy link
Member Author

hidde commented Apr 16, 2021

@slhenry said in EOWG 16 April improve proximity and spacing to better group related info and separate the groups

@hidde
Copy link
Member Author

hidde commented Apr 16, 2021

Kevin said in EOWG 16 April:

long, thin, clutterred page and does not work well in Edge. It is difficult to visually parse. Wasn't there more of a tabular view - is there an option for that kind of view?

@hidde
Copy link
Member Author

hidde commented Apr 16, 2021

Have put Address and Short Name on the same line, made the delete function more subtle with an icon (and under the hood an accessible name), improved visual grouping so that each sampled page looks more like one. The background redundantly reinforces the grouping (low contrast, so only some users will benefit; could add border, but may be too much).

Also: tested in Edge!

@hidde hidde moved this from To do to In PR Review in [2021 Redesign] UI tweaks Apr 16, 2021
@hidde hidde moved this from In PR Review to Done in [2021 Redesign] UI tweaks Apr 16, 2021
@shawna-slh
Copy link

much better spacing and proximity!

(Although personally I would like the field name a little closer to the field -- but no biggie :-)

@hidde
Copy link
Member Author

hidde commented Apr 20, 2021

thanks! I've removed half of the spacing between field name and field (8px to 4px to be precise).

Screenshot 2021-04-20 at 14 37 15

Closing for now, let's rivisit as needed.

@hidde hidde closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants