Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Technique F97: Add related technique G214 #3792

Closed
umut-gultekin opened this issue Apr 22, 2024 · 5 comments · Fixed by #3817
Closed

Technique F97: Add related technique G214 #3792

umut-gultekin opened this issue Apr 22, 2024 · 5 comments · Fixed by #3817
Assignees
@dav-idc
Labels
1.3.4 Orientation Editorial Techniques

Comments

@umut-gultekin
Copy link

G214: Using a control to allow access to content in different orientations which is otherwise restricted
@fstrr
Copy link
Contributor

fstrr commented Apr 22, 2024

@umut-gultekin Did you mean to open this as an issue? If so, could you explain the issue please. If you didn't, please close it. Thanks!

@umut-gultekin
Copy link
Author

@fstrr I am sorry. I pressed the button under the techniques and assumed this was how I was expected to contribute. Is forking and editing the expected way to contribute?

@fstrr
Copy link
Contributor

fstrr commented Apr 23, 2024

Hey, @umut-gultekin. My mistake—you're all good. I was lacking caffeine this morning and wasn't thinking straight.

One thing that would be useful in the future would be to link to the technique that you want something changing in. Instead of just having F97 / F86 / F82, etc. in the title, also link to it in the body of the issue—it makes it quicker to get to what's being talked about :)

Sorry for the comment and thanks for the issues!

@mbgower mbgower changed the title Technique F97: Add related technique Technique F97: Add related technique G214 May 3, 2024
@dav-idc dav-idc self-assigned this May 3, 2024
@dav-idc dav-idc linked a pull request May 3, 2024 that will close this issue
Small edit: Connect G214 and F97 as related techniques #3817
Merged
@dav-idc dav-idc mentioned this issue May 3, 2024
Merged
@dav-idc
Copy link
Contributor

dav-idc commented May 3, 2024

Hey @umut-gultekin I've opened a PR that should link F97 and G214 together as you described.

Would you be able to double-check the changes made, as shown in the pull request?

@umut-gultekin
Copy link
Author

Looks good to me. Thanks @dav-idc

mbgower pushed a commit that referenced this issue Jun 12, 2024
@dav-idc
Small edit: Connect G214 and F97 as related techniques (#3817)
8a6a8f2 
- G214: Fix broken link for F97 related technique
- F97: Add a 'Related Techniques' section
- F97: Add link to technique G214 within the new 'Related Techniques'
section

Fixes the following GitHub issue: 
- #3792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dav-idc dav-idc

Labels
1.3.4 Orientation Editorial Techniques
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Small edit: Connect G214 and F97 as related techniques w3c/wcag
4 participants
@mbgower @fstrr @umut-gultekin @dav-idc