Adding sentence on large text areas #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -232,7 +232,7 @@ <h4>Unusual shapes and gradients</h4> | |||
| <p>Some designs have pages with a non-solid background image covering the whole (or part) of the page or make use of parallax scrolling effects which result in a near-infinite number of color combinations if a page is scrolled and/or changes are made to the viewport size.</p> | |||
| <p>If the contrast of background colors that change are close enough to need to be tested for each combination then they would likely not meet the user need of people with low vision in certain scroll combinations and would likely fail in certain combinations as well. In these cases it would be an easy solution to use a double ring focus indicator or some other mechanism to indicate focus such as a solid box with a border to guarantee there is sufficient contrast across variations of background images or background gradients.</p> | |||
|
|
|||
| <p>Some components may be very large, such as editing areas in a Content Management System or code-editor that fill the screen. There maybe some circumstances where a large editing area may not be as useful, however, it may still be beneficial to some. There is no exception for this scenario.</p> | |||
| <p>Some components may be very large, such as editing areas in a Content Management System or code-editor that fill the screen. There maybe some circumstances where a large focus indicator may not be as useful, however, it may still be beneficial to some. There is no exception for this scenario.</p> | |||
There was a problem hiding this comment.
that , however, looks a bit awkward. perhaps ... may not be as useful. However, it may ... or ... may not be as useful – however, it may ...
There was a problem hiding this comment.
at the very least, "maybe" should be "may be"
Provided update to editing areas text
Issue2017 editing area wording changes
Added caret indicator to address a concern
|
It sounds like we keep going back and forth on this whether it is or is not required. The wording says it won't be beneficial to some but may be to others so it needs to meet the requirements. That's fine with me - but it still feels somewhat squishy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2017