-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite SCR37 as an HTML technique #3024
Conversation
- ARIA APG covers non-HTML modal dialogs, so we don’t need to repeat all of that content here. - SCR37 was very out of date - HTML `dialog` element has cross-browser support now - SCR37 and working example deleted. - note: I couldn’t find any HTML working examples, do didn’t create one for this.
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
thank you @fstrr ! |
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
Changing the title capitalization to sentence case, which appears to be WCAG style
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html removed duplicate word "the"
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html removed duplicate "the" and capitalized the button's label
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
removing colons in "for example" constructs, and replacing with commas
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html realized this is an aria label, not a visible "Close" label, so removing capital
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html typically not two words
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my previous approving review still stands. My suggeted edits here are largely editoral nits / clarifying things further and swapping out some language to allude to other conepts - such as 'inert', or current work happening to implement "invokers" into HTML - setting up vocabulary parity for when that concept/method becomes available.
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
techniques/html/H-creating-dialogs-with-the-html-dialog-element.html
Outdated
Show resolved
Hide resolved
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
…t.html Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Co-authored-by: Scott O'Hara <scottaohara@users.noreply.github.com>
Bring the email conversation to github, Wilco wrote:
I replied:
@WilcoFiers - Does that resolve things, or should we discuss this on a call? |
@WilcoFiers making sure you saw the comment above |
@mbgower If the groups thinks this is the best way to go I can live with it. I would caution that it seems to me most people visiting these pages don't know the difference between normative and informative, and don't know that there are things these documents say need to be tested / or don't allow in the tests, that mismatch the normative text. In this particular example, the previous technique allowed the modal to be the next focusable element, whereas the updated one requires focus to be moved into/onto the modal. I think that matters. Similarly it seems to me that if the focus didn't move back to the original trigger, but to the element after the trigger that would be an acceptable way to build a modal. |
Thanks @WilcoFiers.
That seems like an overall concern with the construction of sufficient techniques in WCAG 2, since none of them are normative, nor are they prescriptive (except to the degree that if an author meets the test, they can be confident they have used a technique the WG felt met the requirement). I've always thought of the sufficient techniques as in-the-moment attempts to document best practices. As such, it makes sense that some will need tweaking or even fall out of relevance or favour over the years. But this sounds like a consideration to bring forward to 3.0 discussions!
As you know, the existing SCR37 never represented the only way to create a dialog, merely one sufficient way. However, I think most people would agree that its test for acceptable is an inferior user experience to that provided in the new technique, which closely matches that in the ARIA Authoring Practices dialog pattern and of course is predominantly the default behaviour built into HTML5. I think the general feeling was that since we have a better native behaviour, it makes sense to keep the sufficient technique focused on that, rather than encouraging authors to make custom dialogs. |
On the topic, we could have simply added a technique, and kept the old one. However, the feeling was that the old one, whilst passing, wasn't really a good practice to suggest these days. Off topic, I know we've looked at this before (quite a long time ago), but perhaps (in a separate issue) we should tweak the standard text above techniques? Current:
Suggestion (change in bold):
If that seems reasonable (e.g. thumbs up) I'll open something up separately. |
dialog
element has cross-browser support nowHere's a githack preview of the page