Skip to content

Commit

Permalink
Don't use variable test titles
Browse files Browse the repository at this point in the history
  • Loading branch information
plehegar committed Jan 22, 2016
1 parent b62f9fa commit 2dc5ca3
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions navigation-timing/test_navigation_type_reload.html
Expand Up @@ -57,7 +57,7 @@
//Verify that the navigation type has updated to reload
test_equals(reload_frame.contentWindow.performance.navigation.type,
performanceNamespace.navigation.TYPE_RELOAD,
'window.performance.navigation.type == TYPE_RELOAD,{help:"http://www.w3.org/TR/navigation-timing/#sec-navigation-info-interface"}');
'window.performance.navigation.type == TYPE_RELOAD');

//Verify that the timing data has been updated into the future
var reloadTime = reload_frame.contentWindow.performance.timing;
Expand All @@ -76,9 +76,9 @@
{
test_greater_than(reloadTime[time],
startingTime[time],
"Reload " + time + "(" + reloadTime[time] + ")" +
"Reload " + time +
" > " +
"Original " + time + "(" + startingTime[time] + ")");
"Original " + time);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion user-timing/test_user_timing_mark.html
Expand Up @@ -183,7 +183,7 @@
// test startTime, allow for an acceptable threshold in the difference between the startTime and the
// expected value for the startTime (loadEventStart + markTestDelay)
test_true(Math.abs(markEntry.startTime - expectedStartTime) <= testThreshold,
markEntryCommand + ".startTime ~== " + expectedStartTime + " (up to " + testThreshold +
markEntryCommand + ".startTime is approximately correct (up to " + testThreshold +
"ms difference allowed)");

// verify entryType
Expand Down
4 changes: 2 additions & 2 deletions user-timing/test_user_timing_measure.html
Expand Up @@ -233,15 +233,15 @@
// test startTime; since for a mark, the startTime is always equal to a mark's value or the value of a
// navigation timing attribute, the actual startTime should match the expected value exactly
test_true(Math.abs(measureEntry.startTime - expectedStartTime) == 0,
measureEntryCommand + ".startTime == " + expectedStartTime);
measureEntryCommand + ".startTime is correct");

// test entryType
test_true(measureEntry.entryType == "measure", measureEntryCommand + ".entryType == \"measure\"");

// test duration, allow for an acceptable threshold in the difference between the actual duration and the
// expected value for the duration
test_true(Math.abs(measureEntry.duration - expectedDuration) <= testThreshold, measureEntryCommand +
".duration ~== " + expectedDuration + " (up to " + testThreshold + "ms difference allowed)");
".duration is approximately correct (up to " + testThreshold + "ms difference allowed)");
}

function test_measure_list(measureEntryList, measureEntryListCommand, measureScenarios)
Expand Down
4 changes: 2 additions & 2 deletions user-timing/test_user_timing_measure_navigation_timing.html
Expand Up @@ -198,15 +198,15 @@
// test startTime; since for a mark, the startTime is always equal to a mark's value or the value of a
// navigation timing attribute, the actual startTime should match the expected value exactly
test_true(Math.abs(measureEntry.startTime - expectedStartTime) == 0,
measureEntryCommand + ".startTime == " + expectedStartTime);
measureEntryCommand + ".startTime is correct");

// test entryType
test_true(measureEntry.entryType == "measure", measureEntryCommand + ".entryType == \"measure\"");

// test duration, allow for an acceptable threshold in the difference between the actual duration and the
// expected value for the duration
test_true(Math.abs(measureEntry.duration - expectedDuration) <= testThreshold, measureEntryCommand +
".duration ~== " + expectedDuration + " (up to " + testThreshold + "ms difference allowed)");
".duration is aproximately correct (up to " + testThreshold + "ms difference allowed)");
}
</script>
</head>
Expand Down

0 comments on commit 2dc5ca3

Please sign in to comment.