Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Expired license test fails with Widevine due to incorrect license #4026

Closed
jrummell-chromium opened this issue Oct 19, 2016 · 5 comments

Comments

@jrummell-chromium
Copy link
Contributor

The test https://www.w3c-test.org/encrypted-media/drm-mp4-playback-temporary-expired.html is failing on Chrome 56.0.2895.0 (latest canary build) with:
assert_approx_equals: expiration attribute should equal provided expiration time expected 1476901853505 +/- 2000 but got NaN

In investigating the reason for the failure, the license provided to update() contains a license that never expires, so returning NaN is correct.

I think that the license issued for this test needs to have a duration specified in order for the session expiration to be set.

@mwatson2
Copy link
Contributor

This is a regression. Plus the test is rather difficult to construct with the existing server support, where I often see clock skew and it rounds up the provided expiration time to (it's view of) the current time.

@mwatson2 mwatson2 self-assigned this Oct 19, 2016
mwatson2 added a commit to mwatson2/web-platform-tests that referenced this issue Oct 19, 2016
@mwatson2
Copy link
Contributor

I think PR #4028 should fix it but welcome your comments.

@ddorwin
Copy link
Contributor

ddorwin commented Oct 21, 2016

@mwatson2, per the second paragraph of the original report, the issue appeared to be that the license was configured incorrectly such that it had no expiration, not that the expiration was incorrect. Do you think this is caused by a timing issue with the request?

@mwatson2
Copy link
Contributor

@ddorwin No, that was caused by the third parameter to the message handler being expiration when it should have been {expiration: expiration}. I forgot to update this file when moving from positional parameters to an object. This is fixed in the PR.

@ddorwin
Copy link
Contributor

ddorwin commented Oct 21, 2016

Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants