Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines starting with # in urltestdata.txt are skipped #618

Closed
zcorpan opened this issue Feb 11, 2014 · 8 comments
Closed

Lines starting with # in urltestdata.txt are skipped #618

zcorpan opened this issue Feb 11, 2014 · 8 comments
Assignees

Comments

@zcorpan
Copy link
Member

zcorpan commented Feb 11, 2014

https://github.com/w3c/web-platform-tests/blob/master/url/urltestdata.txt#L30 is intended to be a test but is a comment. (ack @xiaojunwu )

@annevk
Copy link
Member

annevk commented Feb 11, 2014

This would require some special casing I guess. Not sure what would be clearest. Support #?

@zcorpan
Copy link
Member Author

zcorpan commented May 5, 2014

\# seems like a good solution I think.

@annevk
Copy link
Member

annevk commented May 6, 2014

I'm not super interested in maintaining this. Maybe @azakus is interested now Polymer hosts the JavaScript library?

@sideshowbarker
Copy link
Contributor

I wonder if @smola might be willing to take over maintaining it. galamatias also uses that file in its test harness

@smola
Copy link
Contributor

smola commented May 7, 2014

In galimatias I switched to vim-style comments (prefixed with --). That solved the problem for me. Supporting \# sounds good too.

With respect maintenance, I'll be happy to help.

@zcorpan
Copy link
Member Author

zcorpan commented Aug 15, 2014

-- doesn't seem to solve the problem if you want to test URLs starting with -- :-)

@smola
Copy link
Contributor

smola commented Aug 18, 2014

@zcorpan Of course. \- would be needed. \# is probably the best solution, since # is more widespread than -- for comments. That's bikeshedding anyway ;-)

@hallvors
Copy link
Contributor

hallvors commented Nov 3, 2014

Duplicate of issue #500 or vice versa? Let's say vice versa since this has more comments.

@zcorpan zcorpan closed this as completed in dd6ed31 Nov 4, 2014
annevk added a commit that referenced this issue Nov 4, 2014
Use backslash for url tests starting with #. Fixes #618
rubys added a commit to rubys/rust-url that referenced this issue Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants