Move KeyboardLock API methods to a 'keyboard' object #10111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 20, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-969656
branch
from
47b2598
to
19dd7f8
Compare
Build PASSEDStarted: 2018-03-22 07:36:15 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-969656
branch
2 times, most recently
from
1ac74a6
to
b88be9d
Compare
This change moves the KeyboardLock API methods to a 'keyboard' namespace on the Navigator object. We are doing this work now as there has been a request for additional keyboard functionality that would also be placed on the new keyboard object and we wanted to move the KeyboardLock methods there for consistency before we launch. KeyboardLock API Spec is here: https://w3c.github.io/keyboard-lock/#API Old calling pattern: Navigator.keyboardLock(); Navigator.keyboardUnlock(); New calling pattern: Navigator.keyboard.lock(); Navigator.keyboard.unlock(); Note: The main logic in the KeyboardLock.cpp class and tests is the same as it was, however the file changed enough that git does not recognize it as a file move. BUG=680809 Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4 Reviewed-on: https://chromium-review.googlesource.com/969656 Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Gary Kacmarcik <garykac@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#544996}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-969656
branch
from
b88be9d
to
b55e295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the KeyboardLock API methods to a 'keyboard'
namespace on the Navigator object. We are doing this work now as
there has been a request for additional keyboard functionality that
would also be placed on the new keyboard object and we wanted to
move the KeyboardLock methods there for consistency before we launch.
KeyboardLock API Spec is here:
https://w3c.github.io/keyboard-lock/#API
Old calling pattern:
Navigator.keyboardLock();
Navigator.keyboardUnlock();
New calling pattern:
Navigator.keyboard.lock();
Navigator.keyboard.unlock();
Note: The main logic in the KeyboardLock.cpp class and tests is the
same as it was, however the file changed enough that git does not
recognize it as a file move.
BUG=680809
Change-Id: I234b2ab12d5ecd44c894ed5103863fd96fd548d4
Reviewed-on: https://chromium-review.googlesource.com/969656
Reviewed-by: Philip Jägenstedt foolip@chromium.org
Reviewed-by: Gary Kacmarcik garykac@chromium.org
Reviewed-by: Daniel Cheng dcheng@chromium.org
Commit-Queue: Daniel Cheng dcheng@chromium.org
Cr-Commit-Position: refs/heads/master@{#544996}