Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for AnimationPlayer finished state #1061

Conversation

alsemenov
Copy link
Contributor

tests for AnimationPlayer finished state

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/1824

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@sideshowbarker
Copy link
Contributor

@alsemenov you need to change the line endings in this test file

@sideshowbarker
Copy link
Contributor

@birtles do you have time to review this over at https://critic.hoppipolla.co.uk/r/1824

@birtles
Copy link
Contributor

birtles commented Jul 4, 2014

Sorry, I think @dstockwell was going to look at this.

@sideshowbarker
Copy link
Contributor

@alsemenov @birtles @dstockwell This PR has been waiting on review for almost 6 months now.

@birtles
Copy link
Contributor

birtles commented May 6, 2016

I'm going to close this PR unmerged because we have more focused and up-to-date tests in the tree already for this under web-animations/animation/finished.html and web-animations/animation/onfinish.html.

@birtles birtles closed this May 6, 2016
gsnedders pushed a commit that referenced this pull request Mar 28, 2017
Test DOMMatrixReadOnly methods do not mutate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants