Cookie Store: Move non-ASCII codepoint test cases to dedicated tests #10727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Apr 30, 2018
Cookie handling of non-ASCII codepoints is not consistent across browsers, so we definitely want tests that exercise these. To make potential failures here more obvious, make sure that there are dedicated test cases for non-ASCII interop with other ways of getting/setting cookies (HTTP headers, document.cookie). Also, make the document.cookie interop tests symmetric: set/overwrite/delete by CookieStore observed by document.cookie and vice versa. Bug: 729800 Change-Id: I637401e5f8021a2915ba186fbb1cf7a50e940905 Reviewed-on: https://chromium-review.googlesource.com/1036306 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#554936}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1036306
branch
from
59a1562
to
d61502a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cookie handling of non-ASCII codepoints is not consistent across
browsers, so we definitely want tests that exercise these. To make
potential failures here more obvious, make sure that there are
dedicated test cases for non-ASCII interop with other ways of
getting/setting cookies (HTTP headers, document.cookie).
Also, make the document.cookie interop tests symmetric:
set/overwrite/delete by CookieStore observed by document.cookie and
vice versa.
Bug: 729800
Change-Id: I637401e5f8021a2915ba186fbb1cf7a50e940905
Reviewed-on: https://chromium-review.googlesource.com/1036306
Commit-Queue: Victor Costan pwnall@chromium.org
Reviewed-by: Victor Costan pwnall@chromium.org
Cr-Commit-Position: refs/heads/master@{#554936}