Move AudioParam tests to WPT #10738
Merged
Move AudioParam tests to WPT #10738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 1, 2018
Move many but not all WebAudio AudioParam tests to WPT. The criteria was whether Firefox passed the tests or, if not, the errors are actually bugs in Firefox. Most of the failures are because Firefox threw the wrong type of error. We also skipped over most of the tests that use offline.suspend(). Bug: 745778 Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f Reviewed-on: https://chromium-review.googlesource.com/1036456 Reviewed-by: Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555140}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1036456
branch
from
d25fb4a
to
797bba0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move many but not all WebAudio AudioParam tests to WPT.
The criteria was whether Firefox passed the tests or, if not, the
errors are actually bugs in Firefox. Most of the failures are because
Firefox threw the wrong type of error. We also skipped over most of
the tests that use offline.suspend().
Bug: 745778
Change-Id: If4755089938ddf1b9825faa3392d1d10e3b9293f
Reviewed-on: https://chromium-review.googlesource.com/1036456
Reviewed-by: Hongchan Choi hongchan@chromium.org
Commit-Queue: Raymond Toy rtoy@chromium.org
Cr-Commit-Position: refs/heads/master@{#555140}