Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic mesh tests. #10867

Merged
merged 2 commits into from
Sep 19, 2018
Merged

Add basic mesh tests. #10867

merged 2 commits into from
Sep 19, 2018

Conversation

Tavmjong
Copy link
Contributor

@Tavmjong Tavmjong commented May 7, 2018

SVG 2 Mesh Gradient reference tests.

@longsonr
Copy link
Contributor

longsonr commented May 7, 2018

shouldn't this wait till at least one browser has indicated they plan to implement this?

@ewilligers
Copy link
Contributor

shouldn't this wait till at least one browser has indicated they plan to implement this?

No, mesh is in a spec so adding tests is legitimate.

If we find (e.g. by running the tests) that mesh doesn't have at least two implementations, with at least one implementation being a browser or high quality polyfill, then mesh would be removed from the SVG 2 Draft or at least marked At Risk. The feature might remain in one of the other drafts at https://svgwg.org/ (like other feature proposals cut from SVG 2), and the tests would remain relevant.

(I have no mesh expertise so I have no comment on the quality of the proposed tests.)

@Tavmjong
Copy link
Contributor Author

Tavmjong commented May 9, 2018

Any idea why checks failed?

@ewilligers
Copy link
Contributor

Can someone from InkScape or Adobe please review this.

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunate that the ref is a PNG, there may be changes due to antialiasing, but I can't see a way around that.
The tests look correct to me.
The webfont is unused and thus not needed, but is harmless.

@svgeesus svgeesus merged commit b535ce7 into web-platform-tests:master Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants