IndexedDB: Skip keypath tests for non-cloneable values #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Critic review: https://critic.hoppipolla.co.uk/r/3276 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
zqzhang
added a commit
that referenced
this pull request
Nov 25, 2014
IndexedDB: Skip keypath tests for non-cloneable values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in https://www.w3.org/Bugs/Public/show_bug.cgi?id=26492 we probably want to clone before extracting keys using keypaths. Chrome already does this, other implementers seem to agree. The spec is written in a non-algorithmic style, so it's ambiguous.
With this change, all potential key types are still tested as explicit keys. But a secondary test, embedding potential key values into an object and using implicit keys via key paths, is not done if the value is not cloneable, since it could fail with either DataCloneError (if cloning is done before extraction) or DataError (if cloning is done after extraction).