Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two test cases for WebMessaging message clone #1422

Merged
merged 1 commit into from Nov 27, 2014
Merged

Fix two test cases for WebMessaging message clone #1422

merged 1 commit into from Nov 27, 2014

Conversation

siusin
Copy link
Contributor

@siusin siusin commented Nov 27, 2014

Logical errors in the code. FF and IE will pass after the fix.

Logic errors in the code. FF and IE will pass after the fix.
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3300

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@zcorpan
Copy link
Member

zcorpan commented Nov 27, 2014

w3c-test:mirror

zcorpan added a commit that referenced this pull request Nov 27, 2014
…-fix

Fix two test cases for WebMessaging message clone
@zcorpan zcorpan merged commit 1a1f0d2 into web-platform-tests:master Nov 27, 2014
@AFBarstow
Copy link
Contributor

@siusin @zcorpan thanks for this! FYI, when I run these two tests on FF34 and Opera12.16, I now get passes for the array and object tests (they previously failed [1]). However, for Chrome39.0, the array test still fails (both with and without ports). Thought you might want to know.

[1] http://w3c.github.io/test-results/webmessaging/less-than-2.html

@siusin
Copy link
Contributor Author

siusin commented Nov 27, 2014

@AFBarstow That's great! There are only 6 failures left in the report now.

I think Chrome failed because their output for the structure clone(HTML5 Ch2.7.5) of an array is an indexed array obj, while this test case is expecting a simple array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants