Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for Battery Status API #1488

Merged
merged 2 commits into from
Jan 26, 2015

Conversation

kangxu
Copy link
Contributor

@kangxu kangxu commented Dec 26, 2014

  • According to Battery Status API CR on 09December 2014,we must get BatteryManager object by navigator.getBattery() instead of navigator.battery.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/3589

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

- According to Battery Status API CR on 09December 2014,
we must get BatteryManager object by navigator.getBattery()
instead of navigator.battery.
@zqzhang
Copy link
Contributor

zqzhang commented Dec 30, 2014

w3c-test:mirror

@zqzhang zqzhang closed this Jan 26, 2015
@zqzhang zqzhang reopened this Jan 26, 2015
zqzhang added a commit that referenced this pull request Jan 26, 2015
Update tests for Battery Status API
@zqzhang zqzhang merged commit 05faf38 into web-platform-tests:master Jan 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants