Compact runner UI & add manifest update animation. #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduced the amount of vertical space on tools/runner/index.html page. Only show instructions when page loads; then just show progress/results. Added simple background animation to "updating & loading manifest" text.
|
Critic review: https://critic.hoppipolla.co.uk/r/3648 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
sideshowbarker
added a commit
that referenced
this pull request
Jan 5, 2015
Compact runner UI & add manifest update animation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instructions at the top of the browser-based runner page take up a lot of vertical space and only really need to be shown to users when the page first loads. So this PR moves the instructions to follow the runner (form) controls. After the user starts a test run, the instructions are hidden and just the progress/results are then shown after the runner controls. This seems like better UX to me than showing the instructions all the time.
Also, this PR adds some simple background-color animation to the "updating and loading test manifest" text so that the user knows the runner isn't just hanging. That's to address #1372. Again, it seems like better UX to give some kind of progress indicator during that phase.